Skip to content

feature: support customized timeout for model data download and inference container startup health check for Hosting Endpoints #3388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2022
Merged

feature: support customized timeout for model data download and inference container startup health check for Hosting Endpoints #3388

merged 3 commits into from
Oct 27, 2022

Conversation

chiui0x18
Copy link
Contributor

@chiui0x18 chiui0x18 commented Sep 30, 2022 •
edited
Loading

This change also enables customization of ML instance storage volume size for Hosting Endpoints.

Issue #, if available:

Description of changes:

This change gives customers access to the capability of customizing 1) model data download timeout 2) inference container startup health check timeout and 3) ML instance storage volume size via SageMaker python SDK.

Testing done:

  • Unit tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chiui0x18 chiui0x18 force-pushed the customize-hosting-timeouts branch 2 times, most recently from bfd8403 to 0f4aa0a Compare October 7, 2022 18:01
@claytonparnell claytonparnell force-pushed the customize-hosting-timeouts branch from 0f4aa0a to 9cf6e7f Compare October 19, 2022 17:12
@chiui0x18 chiui0x18 force-pushed the customize-hosting-timeouts branch from a9f61e3 to 852ffdd Compare October 25, 2022 16:23
navinsoni
navinsoni reviewed Oct 25, 2022
View reviewed changes
Copy link
Contributor

@navinsoni navinsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 852ffdd
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 852ffdd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 852ffdd
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 852ffdd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 852ffdd
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@chiui0x18 chiui0x18 requested review from navinsoni and removed request for claytonparnell and mufaddal-rohawala October 26, 2022 20:02
@chiui0x18 chiui0x18 force-pushed the customize-hosting-timeouts branch from 5111ffa to 05f83b5 Compare October 27, 2022 01:01
@chiui0x18
feat: support customized timeout for model data download and inferenc…
41f7538 
…e container startup health check for Hosting Endpoints

This change also enables customization of ML instance storage volume size for Hosting Endpoints.
@chiui0x18
Model and Estimator UTs
b54a41a
@chiui0x18
Formatting and convention fix
4c7c863
@chiui0x18 chiui0x18 force-pushed the customize-hosting-timeouts branch from 05f83b5 to 4c7c863 Compare October 27, 2022 18:03
navinsoni
navinsoni reviewed Oct 27, 2022
View reviewed changes
Copy link
Contributor

@navinsoni navinsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 4c7c863
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

Codecov Report

Merging #3388 (4c7c863) into master (1fa2377) will decrease coverage by 0.34%.
The diff coverage is 83.68%.

@@            Coverage Diff             @@
##           master    #3388      +/-   ##
==========================================
- Coverage   89.17%   88.83%   -0.35%     
==========================================
  Files         204      205       +1     
  Lines       18979    19445     +466     
==========================================
+ Hits        16924    17273     +349     
- Misses       2055     2172     +117
Impacted Files Coverage Δ
src/sagemaker/automl/automl.py 91.32% <ø> (ø)
src/sagemaker/huggingface/model.py 89.87% <ø> (ø)
src/sagemaker/pipeline.py 85.33% <ø> (ø)
src/sagemaker/sklearn/model.py 92.98% <ø> (-1.76%) ⬇️
...sagemaker/workflow/monitor_batch_transform_step.py 0.00% <0.00%> (ø)
src/sagemaker/xgboost/model.py 96.36% <ø> (-1.82%) ⬇️
...agemaker/model_monitor/clarify_model_monitoring.py 89.84% <27.58%> (-5.09%) ⬇️
src/sagemaker/session.py 71.48% <54.54%> (-0.19%) ⬇️
src/sagemaker/training_compiler/config.py 80.43% <60.00%> (-2.90%) ⬇️
src/sagemaker/pytorch/estimator.py 94.73% <63.63%> (-5.27%) ⬇️
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 4c7c863
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 4c7c863
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 4c7c863
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 4c7c863
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@navinsoni navinsoni changed the title feat: support customized timeout for model data download and inference container startup health check for Hosting Endpoints feature: support customized timeout for model data download and inference container startup health check for Hosting Endpoints Oct 27, 2022
@navinsoni navinsoni merged commit 8bcc9e8 into aws:master Oct 27, 2022
mizanfiu pushed a commit to mizanfiu/sagemaker-python-sdk that referenced this pull request Dec 13, 2022
@chiui0x18 @mufiAmazon
feature: support customized timeout for model data download and infer…
fde3a9c 
…ence container startup health check for Hosting Endpoints (aws#3388)
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
@chiui0x18 @JoseJuan98
feature: support customized timeout for model data download and infer…
28abf13 
…ence container startup health check for Hosting Endpoints (aws#3388)
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
@chiui0x18
feature: support customized timeout for model data download and infer…
01dceb0 
…ence container startup health check for Hosting Endpoints (aws#3388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navinsoni navinsoni navinsoni left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chiui0x18 @sagemaker-bot @codecov-commenter @navinsoni